From: NIIBE Y. <gn...@m1...> - 2001-09-05 01:14:38
|
Jeremy Siegel wrote: > Rather than the entire parameter block we copy only the kernel command > line, made configurable (with a copy in misc.c itself so zImage is still > built w/o the empty_zero_page). This allows kernel config to force the > command line regardless of the bootloader, or to not have one and depend > on the bootloader as now. (Or to use sh-ipl+g to load w/o having to set > up the command line using gdb commands.) I think it's good idea to have hard-coded default parameters, and make them configurable. I don't think it's good to "force" the parameters. It should be overridden at run-time. > (Note that the following patch also includes code in misc.c to display > the "Uncompressing Linux..." message w/o the SH BIOS, though it's now > under Solution Engine config flags only.) This part is OK for me. Perhaps, using another config option would be good (CONFIG_SERIAL_CONSOLE and someting), instead of target machine. Besides, for the implementation of default parameters for zImage, I think it could be implemented the file(s) under arch/sh/boot/. > --- kernel/arch/sh/kernel/head.S Fri Jul 27 04:48:29 2001 > +++ test/arch/sh/kernel/head.S Tue Sep 4 14:13:49 2001 I think touching beyond arch/sh/boot/ is irrelevant for this purpose. How about following? (a) Introduce parameter block something like David Woodhouse suggested. (b) Provide the config option to build "zImage + parameter block", say, zImage+parms, and provide options for default paremeters to build parameters block. Users can use zImage+parms with no boot loader, use zImage with boot loader, or use zImage+parms with boot loader which may override params at run-time. -- |