From: NIIBE Y. <gn...@m1...> - 2001-08-20 07:41:22
|
The file asm-sh/segment.h was not created, because it has already been obsoleteat the time when SuperH port started. Someone added the file asm-sh/segment.h into the CVS repository, and I've removed. > Probably because it's easier to create an empty header than fix > all the cruft throughout the kernel. Yes. Technically speaking, adding the file is the wrong thing, removing the inclusion of the file is the right thing. However, in real life, adding the file is good thing, perhaps. > Sure, but does the SuperH team have to be the one to feel this > pressure? It's not a SuperH-specific issue. All other ports has asm/segment.h, so, none will notice about the issue. Only SuperH doesn't have the file from the beginning. > But can we wait with removing segment.h until those changes percolate > back through the mainline kernel? Well, it's OK to add the file containing some comments ("this file should not exist" or something like that). Please do that if you really need it. Perhaps, I don't send it to mainline. I like following implementation, but I guess none agrees :-) --------- asm-sh/segment.h #error "It is obsolete to include this file. Please fix." --------- As time permits, I keep removing the inclusion. -- |