Re: [linuxsh-dev] byteorder.h from elf.h

[NIIBE Y. <gn...@m1...>]

Greg Banks wrote:
 >   I know that for SH, <asm/segment.h> is empty, but it is included
 > in several places in the core kernel.

It's not only for SuperH, please look for other architectures.

For drivers, file system layer, or network layer, including the file
of <asm/segment.h> is obsolete.  In old days, when we needed segment
specification for user process access, it was needed.  The inclusion
of the file has not been needed for quite some time now, say, three
years or so.  It only makes sense for architecture specific code.

Removing the inclusion of asm/segment.h is the way to go.  It seems
that no one (except me) tries to do that.  It's easy to just put empty
segment.h, but then, I will lose the pressure of removing.

 > drivers/cdrom/cdrom.c
 > drivers/input/joydev.c
 > drivers/pcmcia/i82365.c
 > drivers/pcmcia/tcic.c
 > drivers/sound/soundcard.c
 > fs/devfs/base.c

Those are files I've chekced.

Except soundcard.c (which I don't know who is in charge of), I've sent
the fix to relevant maintainers, and positive ACK for cdrom.c,
i82365.c, tcic.c and base.c.  I don't get reply for joydev.c yet.
--