From: Greg B. <gb...@po...> - 2001-08-20 06:21:49
|
NIIBE Yutaka wrote: > > We don't need to include byteorder.h in elf.h. > On an unrelated note, I have a problem with this change: +2001-07-24 NIIBE Yutaka <gn...@m1...> + + * include/asm-sh/segment.h: Removed. + * arch/sh/kernel/pci-sh7751.c: Remove inclusion of <asm/segment.h>. + I know that for SH, <asm/segment.h> is empty, but it is included in several places in the core kernel. Removing the file entirely rather than just leaving it empty means we have to modify mainline files to not include it anymore. This means the following files have pointless one-line differences between the SuperH and mainline kernels: drivers/cdrom/cdrom.c drivers/input/joydev.c drivers/pcmcia/i82365.c drivers/pcmcia/tcic.c drivers/sound/soundcard.c fs/devfs/base.c Trivial diffs in mainline files which provide no actual functionality, create unnecessary problems with maintaining the drop-in tree. So can we please have include/asm-sh/segment.h back? Greg. -- If it's a choice between being a paranoid, hyper-suspicious global village idiot, or a gullible, mega-trusting sheep, I don't look good in mint sauce. - jd, slashdot, 11Feb2000. |