Re: [linuxsh-dev] Cache coherency issue

[SUGIOKA T. <su...@it...>]

At 14:40 01/08/02 +0900, NIIBE Yutaka <gn...@m1...> wrote:
>--- arch/sh/mm/cache-sh4.c	2001/07/28 15:12:46	1.7
>+++ arch/sh/mm/cache-sh4.c	2001/08/02 05:28:39
>@@ -420,7 +444,8 @@
> {
> 	if (((address ^ (unsigned long)to) & CACHE_ALIAS) == 0) {
> 		copy_page(to, from);
>-		__flush_wback_region(to, to+PAGE_SIZE);
>+		__flush_invalidate_region(from, PAGE_SIZE);
>+		__flush_wback_region(to, PAGE_SIZE);
> 	} else {
> 		pgprot_t pgprot = __pgprot(_PAGE_PRESENT | 
> 					   _PAGE_RW | _PAGE_CACHABLE |

>--- arch/sh/mm/__copy_user_page-sh4.S	2001/07/28 14:22:06	1.2
>+++ arch/sh/mm/__copy_user_page-sh4.S	2001/08/02 05:28:39
>@@ -44,7 +44,9 @@
> 	mov.l	@r11+,r4
> 	mov.l	@r11+,r5
> 	mov.l	@r11+,r6
>-	mov.l	@r11+,r7
>+	mov.l	@r11,r7
>+	ocbi	@r11
>+	add	#4,r11
> 	movca.l	r0,@r10
> 	add	#32,r10
> 	mov.l	r7,@-r10

It seems to me that if we use __flush_purge_region()/ocbp here instead of
__flush_invalidate_region()/ocbi then the change of mm/memory.c is not needed.

Isn't it?


----
SUGIOKA Toshinobu