From: Masahiro A. <m-...@aa...> - 2001-06-11 00:11:29
|
On Sun, 10 Jun 2001 14:36:50 +1000 Greg Banks <gn...@al...> wrote: > The rest of the code looks fine to me. > > > I don't want to touch linux/mm/memory.c but couldn't come up with better > > idea than this. > > The reason this seems to be needed is that the hd64465_ss.c code > (which you have copied) uses remap_page_range() to do the job of > ioremap() without having an ioremap(). The ioremap() call is > defined as a null operation on SuperH for good reasons, but it's > actually needed in this case. > > The correct solution would be to compile in the existing but unused > ioremap() code, but rename it to something else like ioremap_real(). > Sadly I am unable to fix this. Thank you for your comment, Greg. I tried to use arch/sh/mm/ioremap.c but it failed to compile since it #includes <asm/io.h> and __ioremap redefinition occurs. I don't know the current state of ioremap.c, why it is not linked into kernel, whether it's still maintained or not, whether it is ok to modify it so that it can be used for this particular case. So, this time I chose the way around. If ioremap.c was created exactly in the way this case needs, then I can try to modify ioremap.c and use it for this case (actually I prefer this). I would like to get advice/opinion about this case from someone who have more insight about this (Niibe-san?), if possible. +-------------------------------------+ | Masahiro Abe, Software Engineer | | A&D Co., Ltd. of Tokyo, Japan | | mailto:m-...@aa... | +-------------------------------------+ |This is my opinion, not my employer's| +-------------------------------------+ |