Re: [linuxsh-dev] [PATCH:] Enhanced RTC Support

[NIIBE Y. <gn...@m1...>]

SUGIOKA Toshinobu wrote:
 > OK, I removed the change of drivers/char/rtc.c ,
 > and added RTC_UIP (RTC updating) bit emulation
 > as your suggestion.

Thanks, please commit it in.

M. R. Brown wrote:
 > There is a problem from my standpoint - this has no hope of working on the
 > Dreamcast, which is a SH7750 (mostly) *without* a working RTC.  This was the
 > reason Philip Rumpf and NIIBE added the mv_rtc_{get,set}timeofday functions
 > to the machvec.  Actually from the LinuxDC side, I have implemented the DC
 > RTC routines (there on the sound chip) and there in the merge that I can
 > hopefully finish and commit this afternoon.

Yes, this is important issue.  Please go ahead.

Note that /dev/rtc is optional device, while {get,set}timeofday is
required feature.  I think that the patch made by Sugioka-san and your
work are basically orthogonal.

Only hwclock uses /dev/rtc.  If we could support IRQ with /dev/rtc,
other (special) software could use it, though.

Hence, I think that the patch by Sugioka-san is quite useful at this
time.

 > What I'm saying is it'd be infinitely cooler to implement this using the
 > machvec routines, where you would never have a problem with compatibility.
 > I had actually starting thinking a bit about this, if you give me a day or so
 > I can try to get a patch for review.

Yes, you could generalize the /dev/rtc more.
--