[linuxsh-dev] (no subject)

[NIIBE Y. <gn...@m1...>]

SUGIOKA Toshinobu wrote:
 > current cvs source tree seems broken around rw_semaphore since few days ago.
 > I just fixed so that it could be build.

Thanks a lot.  I've been sync-ing to/from current pre-patches.  Most
of the work has merged into standard kernel.  Next is dreamcast
drivers.  If there's no objection, I'd like to send Overdrive and
STboard part too.

 > -extern __inline__ void down(struct semaphore * sem)
 > +static inline void down(struct semaphore * sem)

Yes, static inline is good.  The use of extern inline in Linux is old
one (at that time, Linux developpers misunderstood "inline" means
specification but actually it's just a hint to compiler).  Compiler
is free not to expand into inline.

Besides, I think __inline__ (enclosed with __) is better for header
file, if there is possibility for that file to be included by user
program.  User program may be written in K&R, in which the keyword
inline is not supported, and user are free to use the word inline
(say, #define inline).  To avoid conflict, using __ is good idea.
The meaning is same for GCC.

I know that current header files of Linux SH is not consistent...
--