Re: [linuxsh-dev] Misc patches for the DMIDA

[Greg B. <gb...@po...>]

Philipp Rumpf wrote:
> 
> On Fri, Dec 29, 2000 at 04:29:26AM +1100, Mitch Davis wrote:
> > Hello,
> > We would love to hear comments about this patch.
> 
> Random comments (more about the files patched than the patches I fear):
> 
> > diff -X /usr/local/lib/dontdiff -x #*# -x *~ -x vmlinux.lds -u -r --new-file kernel-cvs-20001228/arch/sh/config.in kernel-official/arch/sh/config.in
> > --- kernel-cvs-20001228/arch/sh/config.in     Thu Dec 28 16:59:09 2000
> > +++ kernel-official/arch/sh/config.in Fri Dec 29 01:14:40 2000
> > @@ -77,6 +77,9 @@
> >  mainmenu_option next_comment
> >  comment 'General setup'
> >
> > +# Even on SuperH devices which don't have an ISA bus,
> > +# this variable helps the PCMCIA modules handle
> > +# IRQ requesting properly -- Greg Banks.
> >  define_bool CONFIG_ISA y
> >  define_bool CONFIG_EISA n
> >  define_bool CONFIG_MCA n
> > @@ -187,6 +190,11 @@
> >     endmenu
> >  fi
> >
> > +#
> > +# input before char - char/joystick depends on it. As does USB.
> > +#
> > +source drivers/input/Config.in
> > +
> >  mainmenu_option next_comment
> >  comment 'Character devices'
> >
> 
> Is there any real reason we're not including drivers/char/Config.in ?  Most
> character devices can appear on SuperH, at least in theory, and we're already
> missing important ones (well, softdog is important, IMHO).

  Good question.  Wish I knew the answer.

> 
> > --- kernel-cvs-20001228/drivers/input/keybdev.c       Wed Aug 23 11:36:54 2000
> > +++ kernel-official/drivers/input/keybdev.c   Fri Dec 29 01:14:40 2000
> > @@ -36,7 +36,8 @@
> >  #include <linux/module.h>
> >  #include <linux/kbd_kern.h>
> >
> > -#if defined(CONFIG_X86) || defined(CONFIG_IA64) || defined(__alpha__) || defined(__mips__)
> > +#if defined(CONFIG_X86) || defined(CONFIG_IA64) || defined(__alpha__) || \
> > +    defined(__mips__) || defined(CONFIG_SUPERH)
> 
> not all SuperH machines always use AT scancodes (all of them use PC keycodes
> though, I think).  I'm not sure this is an issue here (since quite frankly
> I don't see how keybdev solves any problems at all).
> 

  I believe it's needed to support USB keyboards.  Note that we haven't
actually achieved that yet, there are still issues getting the HD64465
USB to work.

Greg.
-- 
These are my opinions not PPIs.