Re: [linuxsh-dev] Some patches

[Mitch D. <md...@po...>]

Philipp Rumpf wrote:
> 
> On Fri, Dec 29, 2000 at 03:12:14AM +1100, Mitch Davis wrote:
> > Hello,
> >
> > Here are fixes for some minor problems I've found in the latest kernel:
> >
> >  - "as" does not like single quotes in entry.S and memcpy.S.  The error is like this:
> >
> >    sh-linux-gnu-gcc -D__ASSEMBLY__ -D__KERNEL__ -I/dis/wrk/kernel-compiles/include
> >    -ml -m4   -c -o entry.o entry.S
> >    entry.S:137: unterminated character constant
> >    entry.S:139: unterminated character constant
> >    etc etc etc
> 
> This is a toolchain problem.  I'm surprised you're not seeing the error
> for arch/sh/lib/checksum.S (for which -traditional won't help you) ?

We will be switching to the new toolchain in a couple of days.  So let's
not apply this part of the patch then.

> >  - Philipp's RTC changes weren't added to the generic machine type.
> >    The error:
> >    mach_unknown.c:68: `sh_rtc_gettimeofday' undeclared here (not in a function)
> >
> > Niibe-san, can you check and/or apply this patch please?
> 
> Mea culpa, patch is obviously correct :)

This I will check in.

Thanks for your review Philipp.  (Can you look at the others please?)

Regards,

Mitch.