Re: [linuxsh-dev] Some patches

[Philipp R. <pr...@pa...>]

On Fri, Dec 29, 2000 at 03:12:14AM +1100, Mitch Davis wrote:
> Hello,
> 
> Here are fixes for some minor problems I've found in the latest kernel:
> 
>  - "as" does not like single quotes in entry.S and memcpy.S.  The error is like this:
>  
>    sh-linux-gnu-gcc -D__ASSEMBLY__ -D__KERNEL__ -I/dis/wrk/kernel-compiles/include 
>    -ml -m4   -c -o entry.o entry.S
>    entry.S:137: unterminated character constant
>    entry.S:139: unterminated character constant
>    etc etc etc

This is a toolchain problem.  I'm surprised you're not seeing the error
for arch/sh/lib/checksum.S (for which -traditional won't help you) ?

>  and
> 
>    sh-linux-gnu-gcc -D__ASSEMBLY__ -D__KERNEL__ 
>    -I/dis/wrk/kernel-compiles/include -ml -m4   -c -o memcpy.o memcpy.S
>    memcpy.S:23: unterminated character constant
> 
>    Adding the "EXTRA_AFLAGS = -traditional" fixes it.

Can you check whether using up-to-date binutils works as well ?

>  - Philipp's RTC changes weren't added to the generic machine type.
>    The error:
>    sh-linux-gnu-gcc -D__KERNEL__ -I/dis/wrk/kernel-compiles/include -Wall
>    -Wstrict-prototypes -O2 -fomit-frame-pointer -fno-strict-aliasing -ml
>    -m4 -pipe    -c -o  mach_unknown.o mach_unknown.c
>    mach_unknown.c:68: `sh_rtc_gettimeofday' undeclared here (not in a function)
>    mach_unknown.c:68: initializer element is not constant
>    mach_unknown.c:68: (near initialization for `mv_unknown.mv_rtc_gettimeofday')
> 
> Niibe-san, can you check and/or apply this patch please?

Mea culpa, patch is obviously correct :)