[linuxsh-dev] Re: [PATCH] EC3104/Aero 8000 support, RTC generalization

[Philipp R. <pr...@pa...>]

On Tue, Dec 26, 2000 at 09:09:06AM +0900, NIIBE Yutaka wrote:
> Thanks, installed.
> 
> One note.  In epson1355fb.c, there're duplication of include files, 
> is this right?

Thanks for pointing that out.  It shouldn't hurt to duplicate #includes,
but here's the sorted version anyway:

--- linuxsh/kernel/drivers/video/epson1355fb.c	Mon Dec 25 16:07:13 2000
+++ linux-aero/drivers/video/epson1355fb.c	Mon Dec 25 16:31:15 2000
@@ -17,39 +17,20 @@
  * hw cursor support
  */
 
-#include <linux/init.h>
-#include <linux/sched.h>
-#include <linux/mm.h>
 #include <asm/io.h>
-#include <linux/module.h>
-#include <linux/kernel.h>
-
-#include <linux/module.h>
-#include <linux/kernel.h>
-#include <linux/errno.h>
-#include <linux/string.h>
-#include <linux/mm.h>
-#include <linux/tty.h>
-#include <linux/malloc.h>
 #include <linux/delay.h>
+#include <linux/errno.h>
 #include <linux/fb.h>
 #include <linux/init.h>
-
-#include <video/fbcon.h>
-#include <video/fbcon-mfb.h>
-#include <video/fbcon-cfb8.h>
-
-#include <linux/module.h>
 #include <linux/kernel.h>
-#include <linux/errno.h>
-#include <linux/string.h>
+#include <linux/malloc.h>
 #include <linux/mm.h>
+#include <linux/module.h>
+#include <linux/sched.h>
+#include <linux/string.h>
 #include <linux/tty.h>
-#include <linux/malloc.h>
-#include <linux/delay.h>
-#include <linux/fb.h>
-#include <linux/init.h>
-
+#include <video/fbcon-cfb8.h>
+#include <video/fbcon-mfb.h>
 #include <video/fbcon.h>
 
 /* Register defines.  The docs don't seem to provide nice mnemonic names