From: Rene M. <re...@dr...> - 2000-12-05 14:32:32
|
Philipp Rumpf wrote: > > > > > If you ask me the best way is to use the Make scripts. > > > > Adding a CONFIG_SH_DREAMCAST to the script and the adding > > obviously > > > and extra (binary preselected) option depending on it called > > CONFIG_SH_USE_DREAMCAST_RTC. Then use std #ifdefs to switch at compile > > #ifdef is ugly. ifdef in Makefiles is a lot nicer. I cant say I have an opinion on the subject. Exept that the later needs more work. But sure its nicer. > > > time. Either you are building for the DC or you are not. And there is no > > I agree, but Niibe did integrate "generic build" support and I think it's > impolite to refuse to co-operate with that. From my point of view the GENERIC platform is a nice idea and if people think we should extend it to involve RTC support too fine by me. But I think we should keep the DC out of it at least until the DC-port is complete. The DC is a hack as it is and has very little in common with all the other platforms. Not to mention the obvious risk that we break things again (and there by creating more trouble for everyone). > > > point involving the other platforms. Moving the rtc to a separate file > > is a good idear. But then again. To me it looks like the entire time.c > > has to be rewritten to fit the DC. Its not just the get_rtc_time thats > > the problem but also get_timer_frequency(void) and others. > > Why ? The rest of time.c uses standard onchip SH-4 features, and I think > it should work well even on DC (I don't have one though, want to send me > one ;) ?). Well because the entire time.c seams to me like a hack... And they all use std SH rtc the hardware way. So when the wait for a 1/128s on a DC they will wait forever, since there is no functioning RTC there. /Rene |