[linuxsh-dev] BareCPU build patch/sh_ksyms.c warning patch

[Bryan R. <br...@ix...>]

Hello NIIBE-san and linuxsh-dev,

When trying to build the latest CVS kernel with a machine type of
"BareCPU" the build fails on setup.c:

sh-linux-gnu-gcc -D__KERNEL__ -I/home/bryan/src/sh/kernel/include -Wall
-Wstrict-prototypes -O2 -fomit-frame-pointer -ml -m4 -pipe
-fno-strict-aliasing    -c -o setup.o setup.c
setup.c: In function `setup_arch':
setup.c:311: `mv_unknown' undeclared (first use in this function)
setup.c:311: (Each undeclared identifier is reported only once
setup.c:311: for each function it appears in.)
make[1]: *** [setup.o] Error 1

This error is because there is no extern declaration for mv_unknown when
building with CONFIG_SH_UNKNOWN. Here's my patch, which I believe is
correct:

--- arch/sh/kernel/setup-old.c  Sat Oct 14 14:03:08 2000
+++ arch/sh/kernel/setup.c      Sat Oct 14 13:54:40 2000
@@ -269,6 +269,10 @@
        int mv_mmio_enable = 0;
        unsigned long bootmap_size;
        unsigned long start_pfn, max_pfn, max_low_pfn;
+       
+#ifdef CONFIG_SH_UNKNOWN
+       extern struct sh_machine_vector mv_unknown;
+#endif
 
 #ifdef CONFIG_SH_EARLY_PRINTK
        sh_console_init();

I also made a stupid mistake on my previous sh_ksyms.c patch by using
"arch/sh/lib/*.S" inside of a comment. The compiler sees "/*" and warns
about a comment inside of a comment. Here's the fix:

--- sh_ksyms-old.c      Sat Oct 14 14:03:08 2000
+++ sh_ksyms.c  Sat Oct 14 14:12:54 2000
@@ -49,7 +49,7 @@
 EXPORT_SYMBOL(memset);
 EXPORT_SYMBOL(memmove);
 
-/* this is not provided by arch/sh/lib/*.S but is
+/* this is not provided by arch/sh/lib/mem*.S but is
    potentially needed by modules (af_packet.o/unix.o
    use memcmp, for instance) */
 EXPORT_SYMBOL(memcmp);

Also, in the latest CVS sh_ksyms.c I had to comment out
"EXPORT_SYMBOL(dispatch_virtual_irq);" to get the file to build. I think
this is related to Greg's PCMCIA changes and will eventually go away on
its own, so I did not include that change in the above sh_ksyms.c
patch...

Regards,

Bryan

-- 
Bryan Rittmeyer
mailto:br...@ix...
Ixia Communications
26601 W. Agoura Rd.
Calabasas, CA 91302