Re: [linuxsh-dev] PCMCIA patch & question

[Greg B. <gb...@po...>]

NIIBE Yutaka wrote:
> 
> NIIBE Yutaka wrote:
>  > I'll do the changes of optimizing PGD and removing set_pgdir for SuperH.
> 
> Done.

  Looks good, as far as I can understand it ;-)  Except for ....

> 
> ===================================================================
> RCS file: /cvsroot/linuxsh/kernel/arch/sh/mm/ioremap.c,v
> retrieving revision 1.1.1.1
> diff -u -p -r1.1.1.1 ioremap.c
> --- arch/sh/mm/ioremap.c        2000/04/14 16:49:01     1.1.1.1
> +++ arch/sh/mm/ioremap.c        2000/10/13 02:14:17
> @@ -17,6 +17,9 @@ static inline void remap_area_pte(pte_t
>         unsigned long phys_addr, unsigned long flags)
>  {
>         unsigned long end;
> +       pgprot_t pgprot = __pgprot(_PAGE_PRESENT | _PAGE_RW |
> +                                  _PAGE_DIRTY | _PAGE_ACCESSED |
> +                                  _PAGE_HW_SHARED | _PAGE_FLAGS_HARD | flags);

   Is _PAGE_HW_SHARED right for kernel-only mappings?  I'm not sure
of the implications...

Greg.
-- 
These are my opinions not PPIs.