[linuxsh-dev] PCMCIA patch & question

[NIIBE Y. <gn...@ch...>]

My network connection is quite bad these days, because of the
restructuring of my company.  I think I can be "in sync" this weekend.

For the patch by Greg, here's my comment.

+++ kernel/arch/sh/config.in	Fri Sep 29 03:13:26 2000
+++ kernel/arch/sh/kernel/Makefile	Wed Sep 27 03:28:54 2000
+++ kernel/arch/sh/kernel/sh_ksyms.c	Tue Oct 10 19:56:39 2000
+++ kernel/include/asm-sh/io.h	Wed Sep 27 10:11:34 2000
+++ kernel/include/asm-sh/mmu_context.h	Sun Oct  1 13:18:06 2000
+++ kernel/include/asm-sh/machvec.h	Sat Sep 23 05:34:00 2000
+++ kernel/include/asm-sh/io_hd64461.h	Sat Sep 23 05:21:26 2000
+++ kernel/arch/sh/mm/fault.c	Sun Oct  1 13:56:02 2000

OK.

+++ kernel/arch/sh/kernel/io_hd64465.c	Sun Oct  1 04:57:59 2000
+++ kernel/arch/sh/kernel/mach_foobar.c	Sat Sep 30 10:59:41 2000
+++ kernel/arch/sh/kernel/setup_hd64465.c	Tue Oct 10 20:02:53 2000
+++ kernel/include/asm-sh/hd64465.h	Sat Sep 30 11:00:17 2000
+++ kernel/include/asm-sh/io_hd64465.h	Tue Oct 10 20:18:29 2000

OK.

+++ kernel/drivers/pcmcia/Config.in	Mon Sep 25 23:41:41 2000
+++ kernel/drivers/pcmcia/Makefile	Mon Sep 25 23:54:05 2000
+++ kernel/drivers/pcmcia/hd64465_ss.c	Tue Oct 10 20:14:28 2000

OK for me.  (Actually I don't care. :-)  Could you please send this part
to PCMCIA driver maintainer directly?

Please check them in.
----------------------------------------------

+++ kernel/arch/sh/kernel/io.c	Fri Sep 29 09:44:43 2000
+++ kernel/arch/sh/kernel/io_generic.c	Tue Sep 26 01:59:37 2000

For those, I'm not sure now.  EXPORT_SYMBOL shoule be here or in sh_ksyms.c.

+++ kernel/include/asm-sh/irq.h	Tue Oct 10 22:27:45 2000

Basically OK.  But I'm not sure about the implementation of
dispatch_virtual_irq.

+++ kernel/arch/sh/kernel/irq.c	Tue Oct 10 19:56:23 2000
+int dispatch_virtual_irq(unsigned int irq, struct pt_regs * regs)

Please let me think for a while for this.

+++ kernel/include/asm-sh/ide.h	Fri Sep 29 06:10:52 2000
+#define NO_ONBOARD_IDE 1

Umm... it looks not good.  Pending.

+++ kernel/include/asm-sh/pgtable.h	Sun Oct  1 12:01:12 2000

Currently I don't understand this.  Please give me more time.
--