[linuxsh-dev] HP600 updates

[NIIBE Y. <gn...@ch...>]

YAEGASHI Takeshi wrote:
 > Introduced new machine vectors(hp620, hp680, hp690) and now we
 > could support all of them more easily.

Looks good for me.

One thing I think we need improve is:

 > --- kernel/include/asm-sh/machvec.h:1.1.1.2	Tue Aug  1 23:23:17 2000
 > +++ kernel/include/asm-sh/machvec.h	Sun Sep 17 14:58:36 2000
 > @@ -65,6 +65,9 @@
 >  
 >  	unsigned int mv_hw_se : 1;
 >  	unsigned int mv_hw_hp600 : 1;
 > +	unsigned int mv_hw_hp620 : 1;
 > +	unsigned int mv_hw_hp680 : 1;
 > +	unsigned int mv_hw_hp690 : 1;
 >  	unsigned int mv_hw_hd64461 : 1;
 >  };
 >  
 > @@ -74,6 +77,9 @@
 >  #ifdef CONFIG_SH_GENERIC
 >  #define MACH_SE		(sh_mv.mv_hw_se)
 >  #define MACH_HP600	(sh_mv.mv_hw_hp600)
 > +#define MACH_HP620	(sh_mv.mv_hw_hp620)
 > +#define MACH_HP680	(sh_mv.mv_hw_hp680)
 > +#define MACH_HP690	(sh_mv.mv_hw_hp690)
 >  #define MACH_HD64461	(sh_mv.mv_hw_hd64461)
 >  #else
 >  # ifdef CONFIG_SH_SOLUTION_ENGINE
 > @@ -85,6 +91,21 @@
 >  #  define MACH_HP600		1
 >  # else
 >  #  define MACH_HP600		0
 > +# endif
 > +# ifdef CONFIG_SH_HP620
 > +#  define MACH_HP620		1
 > +# else
 > +#  define MACH_HP620		0
 > +# endif
 > +# ifdef CONFIG_SH_HP680
 > +#  define MACH_HP680		1
 > +# else
 > +#  define MACH_HP680		0
 > +# endif
 > +# ifdef CONFIG_SH_HP690
 > +#  define MACH_HP690		1
 > +# else
 > +#  define MACH_HP690		0
 >  # endif
 >  # ifdef CONFIG_HD64461
 >  #  define MACH_HD64461		1

This does not scale well.  And it's not need to be a bit, as the
hardware is mutually exclusive.  Well, consider later.
--