[linuxsh-dev] SCI error handling

[NIIBE Y. <gn...@ch...>]

YAEGASHI Takeshi wrote:
 > Attached patch adds error handling to SCI.  Tested on SH-4 and
 > HP690.
[...]
 > Any comments?  I would check it in later.

Good job.  Two comments:

(1) Why do you set TEI handler?  It's not worth to add it for XXX_IRQ
    macros and the interrupt vectors, as we never use TEI interrupt in
    the driver.  The driver is not the specification of the SCI, it's
    the software which _use_ SCI.  If needed, people could get
    hardware manual.  Just add for BRI is enough, I think.

(2) Break handling
    I think that we could find break condition with SCI when some
    error occurs.  Then, call break handling routine.  Isn't it
    possible?
--