Re: [linuxsh-dev] sh_console_unregister

[Mitch D. <mj...@al...>]

NIIBE Yutaka wrote:
> 
> I'm preparing the update patch (to mainstream).  To avoid the changes
> small, I'd like to apply following changes for console handling.
> 
> I assume that EARLY_PRINTK feature is for SH serial console only, so
> it's OK to place calling unregister routine at SCI driver.
> 
> Yes, if someone extend the BIOS to support other serial chiip, this
> is not good.  But until that time, I think this is good thing.

Hi Niibe-san,

There is already heaps of platform-specific stuff in tty_io.c.
In fact, from the time we wrote that code, to the time I checked
it in, someone else from some other project (ARM Linux I think)
had made a change and caused a conflict in that spot.  It seems
that's the place people put things like this.

> Yes, if someone extend the BIOS to support other serial chiip, this
> is not good.  But until that time, I think this is good thing.

Or maybe it's not even a serial port.  I have a backlit 40 char
by 2 line LCD display I'm trying to connect, and I want to modify
the stub to use this instead of the serial output.  If the
early printk unregister is put into sh-sci.c, this is more
difficult.

It's only a few lines, and it's surrounded by other very platform-
specific registrations.  The call is yours, but I would prefer
to see it stay in tty_io.c.

BTW the patch in your message add the line "rio_init".  Did I
accidentally remove that when resolving the conflict?  (Hope not)

Regards,

Mitch.
--
mailto:mj...@al... | Certified Linux Evangelist!