[linuxsh-dev] Assorted patches for Linux kernel, and the stub.

[NIIBE Y. <gn...@ch...>]

Mitch Davis wrote:
 > As Greg indicated in his earlier email, here are the diffs we
 > have been working on.  There's a patch for the kernel code, and
 > a patch for the stub.

Thanks for your effort.  It's great contribution.

Here're some comments:

 > x  Link script sets Load Memory Addresses so that kernel image
 >    load bypasses the cache, to avoid cache problems.

No, this is backward.  If you have any problems, please send us bug
report.  The changes like this just paper the bugs, and hide them.
It's not the solution.  Major problem is it loses performance.
Besides, I don't know the problem around cache issues, which is
solved with this change.

It seems for me that what to change is GDB stub, if needed.

 > --- kernel-orig/arch/sh/kernel/sh_bios.c	Thu Jan  1 10:00:00 1970
 > +++ kernel/arch/sh/kernel/sh_bios.c	Tue Jul 18 03:57:22 2000
 > @@ -0,0 +1,70 @@
 > +/* $Id$
 > + *
 > + *  linux/arch/sh/kernel/sh-bios.c
 > + *  C interface for trapping into the standard LinuxSH BIOS.
 > + *
 > + *  Copyright (C) 2000 Greg Banks, Mitch Davis
 > + *
 > + */

It would be good if we have license notice here (which I sometimes
forgot).  Please look arch/sh/kernel/entry.S for example.

Well done.  Please check them (except the Load Memory Addresses thing)
in.  May I ask you to incorporate changes of sh-sci.c,h done by
Stuart?  It seems that he's off-line nowadays.  I'm thinking send our
update to Linus.  I'll incorporate his other changes, if he won't.

 > This is a patch against the gdb stub version 2000-06-22.  The
 > following is a description of changes.

I'll incorporate this changes.  Thanks.
--