Re: [linuxsh-dev] patch: Multiple SCI(F)s support

[YAEGASHI T. <yae...@ma...>]

Hello Stuart,

Sorry I don't test "multiple" feature of your patch yet.  It
seems quite easy to add support for more SCIF(IrDA).

I see it works on my HP690(SCIF only).  But according to
/proc/interrupts, it seems to me that somewhat too many TXI
interrupts occur.


--- 352,369 ----
        }
  
        save_and_cli(flags);
!       ctrl = sci_in(port, SCSCR);
        if (port->gs.xmit_cnt == 0) {
                ctrl &= ~SCI_CTRL_FLAGS_TIE;
                port->gs.flags &= ~GS_TX_INTEN;
        } else {
!               if (port->type == PORT_SCIF) {
!                       sci_in(port, SCxSR); /* Dummy read */
!                       sci_out(port, SCxSR, SCIF_TDFE);

I think this should be: sci_out(port, SCxSR, ~SCIF_TDFE);
Correct?


And at first it cannnot communicate at 115.2Kbps because of the
insufficient precision of clock measurement.  This change might
be needed to improve it...

--- sh-sci.h.orig       Tue Jun 20 14:27:12 2000
+++ sh-sci.h    Tue Jun 20 14:27:30 2000
@@ -264,7 +264,7 @@
 
 #define PCLK           (current_cpu_data.module_clock)
 
-#define SCBRR_VALUE(bps) (PCLK/(32*bps)-1)
+#define SCBRR_VALUE(bps) ((PCLK+16*bps)/(32*bps)-1)
 #define BPS_2400       SCBRR_VALUE(2400)
 #define BPS_4800       SCBRR_VALUE(4800)
 #define BPS_9600       SCBRR_VALUE(9600)



> Please check in.  Then, let's assign new device number for it.
> I think that we need CONFIG_SCI_SERIAL again.
> 
> The rationale for new device number is: some boards has same serial
> chip as PC and he may want to use standard serial driver.

Yes, please go ahead with checking in.  I would like to drive
16550A's in HD64461.

--
YAEGASHI Takeshi <yae...@ma...>