[linuxsh-dev] Solution Engin's ATA PC-card enabler

[NIIBE Y. <gn...@ch...>]

Toshiharu Nozawa wrote:
 > I made enabler of the ATA card which I used the PC card 
 > slot on Solution Engine for.

Nice work.  Questions:

	(1) Does it work on other SolutionEngin(s)?  SH7709? SH7709A?

Here's comments.

 > --- linux-2.4.0-test1/arch/sh/config.in	Sun May 21 04:05:29 2000
 > +++ linux-sh/arch/sh/config.in	Wed Jun  7 01:13:01 2000
 > @@ -61,9 +61,9 @@
 >  
 >  bool 'Networking support' CONFIG_NET
 >  
 > -if [ "$CONFIG_SH_SOLUTION_ENGINE" != "y" ]; then
 > +#if [ "$CONFIG_SH_SOLUTION_ENGINE" != "y" ]; then
 >     bool 'Directly Connected Compact Flash support' CONFIG_CF_ENABLER
 > -fi
 > +#fi
 >  
 >  bool 'PCI support' CONFIG_PCI
 >  if [ "$CONFIG_PCI" = "y" ]; then

We should change the explanation.  For solution engine, it's nof
"Directly Connected Compact Flash Support".  I'd just use:
"Compact Flash Enabler".

 > --- linux-2.4.0-test1/arch/sh/kernel/cf-enabler.c	Mon Mar  6 02:33:55
 > 2000
 > +++ linux-sh/arch/sh/kernel/cf-enabler.c	Wed Jun  7 12:22:14 2000

Will applied.

 > --- linux-2.4.0-test1/include/asm-sh/hitachi_se.h	Sun May 21 04:05:30
 > 2000
 > +++ linux-sh/include/asm-sh/hitachi_se.h	Wed Jun  7 12:11:43 2000

Ditto.  These two are no problem.

For the changes of following file:

 > --- linux-2.4.0-test1/arch/sh/kernel/io_se.c	Mon May 22 12:55:06 2000
 > +++ linux-sh/arch/sh/kernel/io_se.c	Wed Jun  7 12:55:33 2000

I'd like to listen comment from Kaz.  It seems there's some conflict
on usage of sh_pcic_XXX semantics.
--