Re: [linuxsh-dev] HP600 patch

[<mj...@al...>]

Dear Takeshi,

>Ok, here is the patch against linux-sh-2000-06-05.diff.gz from
>m17n.org

Boy, this is a lot of work.  Congratulations.  And I'm
very glad to see it go into the CVS kernel.  Especially
the 64461 work!

>+	Would anyone design and contribute our logo? :->

I believe Stuart Menefy had Tux in a hammock having a
sleep (Shhh!  Get it?).  That would make a good logo.

>-	 SolutionEngine		CONFIG_SH_SOLUTION_ENGINE" Generic
>+	 SolutionEngine		CONFIG_SH_SOLUTION_ENGINE	\
>+	 HP600			CONFIG_SH_HP600" Generic

Is this support applicable to other models in the 600
series?  Might "6x0" be an idea?

Also, is there an entry in Configure.help for the new
defines?

linux/arch/sh/kernel/hd64461.c
>--- linux-2.4.0-test1.orig/arch/sh/kernel/hd64461.c	Thu Jan  1 09:00:00 1970

>+++ linux/arch/sh/kernel/hd64461.c	Tue Jun  6 17:36:10 2000
>+static void __init setup_hd64461(void)
>+{
>+	int i;
>+
>+	printk(KERN_INFO "HD64461 at 0x%x on irq %d (%d - %d)

Usually kernel messages like this come up because the device
has been detected (cf being manually configured).  I would
suggest either the word "detected" or "configured" after the
HD64461.  Otherwise people might think the kernel is
confirming through detection something that exists because
it's been configured.

>+++ linux/arch/sh/kernel/time.c	Tue Jun  6 17:38:38 2000
>+#ifdef CONFIG_SH_HP600
>+		master_clock = cpu_clock/6;
>+#else
> 		master_clock = cpu_clock;
>+#endif

Where does the 6 come from?  Suggest a comment here, or
move it to a header file (with a comment).

>+++ linux/drivers/char/scan_keyb.c	Tue Jun  6 17:37:17 2000
> #if defined(CONFIG_CPU_SUBTYPE_SH7709)
>+#ifdef CONFIG_SH_HP600
>+#define PCLK           22222222
>+#else
> #define PCLK           33333333
>+#endif

Suggest comments?

>+   if [ "$CONFIG_HD64461" = "y" ]; then
>+      tristate '  HD64461 Frame Buffer support' CONFIG_FB_HIT
>+   fi

Is there a description in Configure.help.

>+++ linux/include/asm-sh/linux_logo.h	Tue Jun  6 19:19:49 2000
>@@ -0,0 +1,48 @@
>+/* $Id: linux_logo.h,v 1.1 2000/03/24 04:03:16 keshi Exp $
>+ * include/asm-i386/linux_logo.h: This is a linux logo

s/i386/sh/

>+#define linux_logo_banner "Linux/ia32 version " UTS_RELEASE

s/ia32/SuperH/

Nice job!
http://www.alphalink.com.au/