Re: insw broken for SH4?

[Paul M. <le...@li...>]

On Sat, Nov 10, 2007 at 03:25:08PM +0000, Adrian McMenamin wrote:
> On Sun, 2007-11-11 at 00:21 +0900, Paul Mundt wrote:
> > The bogus address you're hitting is a result of the address wrapping
> > around. So I suggest you change your DATA_REG to 0x05f7080 and see how
> > that goes.
> 
> I'm just going to write my own functions for this based on the SH64 ones
> - or at least the ones that were in SH64

What on earth for? You should be letting ioport_map() take care of the
segment offset for you, rather than trying to hack around it. Fix your
register addresses, don't hack around them with bogus I/O routines.

The SH64 ones are in the progress of switching over to the stock SH ones,
primarily because of this reason (and the fact that P1/P2 assumptions are
just bogus on quite a number of CPUs at this point, so having the generic
routines do the right thing is the only portable way to go)..