Re: rts7751r2d cf_ide rework

[Paul M. <le...@li...>]

On Tue, Nov 06, 2007 at 08:43:16PM +0900, Magnus Damm wrote:
> On Sep 21, 2007 3:07 PM, Paul Mundt <le...@li...> wrote:
> > On Sat, Sep 15, 2007 at 11:00:46AM +0900, shinkoi2005 wrote:
> > >  > Is the libata code working properly with 8 bit reads? Is this patch
> > >  > all it takes to get CF working on R2D-1?
> > >
> > > At least, cf_ide_resources[](register map) is also incorrect with R2D-PLUS.
> > > Please check follow kernel which support P2D-PLUS and AT/PC arch's ATA register map.
> > > <http://www.superh-linux.org/archive/bsp/sh7751r_r2d/linux-2.6.14.4-R2D+_20060906.tar.bz2>
> > > R2D* board's ide register map is compatible without register access size.
> > >
> > > Here is the same patch...
> > > I can boot R2D-1 from IDE's rootfs with this patch.
> > >
> > I suppose we can do this, I'll tidy up the patch a bit and apply it,
> > thanks. It's probably worth doing the same thing for R7780RP, at least
> > for the 2 or 3 people that have one of those antiquated things :-)
> 
> I happen to have two of these R2D-1 boards and I can't get CF working
> using the latest kernel (latest sh-2.6 git, post 2.6.24-rc1) :
> 
> ...
> irq 107: nobody cared (try booting with the "irqpoll" option)
> [stack dump]
> [call trace]
> handlers:
> [<8c24f660>] (ata_interrupt+0x0/0x240)
> Disabling IRQ #107
> ...
> 
Did R2D-1 CF work for you with IRQs prior to this change? And does
reverting it fix get R2D-1 CF working again? The nobody cared thing is
curious, if you can provide the stack dump/call trace and register state
it might shed some light on why ata_interrupt isn't handling it.

You may also want to hack up some debug stuff that dumps out the IRQ desc
state for IRQ #107, to make sure that nothing is being clobbered.

> I can get things working by hacking in code to enable polling in
> pata_platform.c though, so I assume that the IO-ports are ok.
> 
It might be worthwhile making the polling configurable, if you want to
tidy up a patch for that we can see if it's something work abstracting.
It's handy for debugging, at least.