Re: [RFC PATCH] I2C bus driver for SH7760 SoC

[Paul M. <le...@li...>]

On Mon, Nov 05, 2007 at 06:17:17PM +0100, Manuel Lauss wrote:
> On Tue, Oct 30, 2007 at 09:27:17AM +0900, Paul Mundt wrote:
> > > +	id->iobase = (void __iomem *)res->start;
> > 
> > You should be ioremap()'ing or ioport_map()'ing this. Either one should
> > be sane here. Presently this will whine if you use 64-bit resources. The
> > existing in-tree users that do this casting need to be changed also.
> 
> Hm, who'd want to enable 64bit resources on a CPU with a 29bit external
> address space? ;)

SH-X and later cores extend this to 32-bit physical, and it's likely that
this will be expanded in the not so distant future. We already need to
use 64-bit PTEs all over the place on SH-X2 and later, and it's
forseeable that the addressing bits will follow.

The 29-bit physical thing is purely legacy cruft at this point, even if
the SH-X cores do an abysmal job of breaking the native 32-bit boot pin
out of the package ;-)