Re: __copy_user bug

[Stuart M. <stu...@st...>]

Looking at the code, there is a movca.l in there, which IIRC isn't
available on an SH3.

Although given that, I don't understand how this even builds.

So try this:

Index: linux-2.6.23.1-stm/arch/sh/mm/copy_page.S
===================================================================
--- linux-2.6.23.1-stm.orig/arch/sh/mm/copy_page.S
+++ linux-2.6.23.1-stm/arch/sh/mm/copy_page.S
@@ -256,7 +256,11 @@ EX(	mov.l	@r5+,r8		)
 EX(	mov.l	@r5+,r9		)
 EX(	mov.l	@r5+,r10	)
 EX(	mov.l	@r5+,r11	)
+#if defined(CONFIG_CPU_SH4)
 EX(	movca.l	r0,@r4		)
+#else
+EX(	mov.l	r0,@r4		)
+#endif
 	add	#-32, r6
 EX(	mov.l	r1,@(4,r4)	)
 	mov	#32, r0


Kristoffer Ericson wrote:
> Greetings,
>
> Haven't had any feedback so far. I would want that the __copy_user patch got reverted since it obviously doesn't work on atleast SH7709A.
> I guess we could ifdef it, but will just make it ugly.
> I stand little chance of fixing it myself without Stuarts help.
>
> Best wishes
> Kristoffer
>
> -------------------------------------------------------------------------
> This SF.net email is sponsored by: Splunk Inc.
> Still grepping through log files to find problems?  Stop.
> Now Search log events and configuration files using AJAX and a browser.
> Download your FREE copy of Splunk now >> http://get.splunk.com/
> _______________________________________________
> linuxsh-dev mailing list
> lin...@li...
> https://lists.sourceforge.net/lists/listinfo/linuxsh-dev