Re: [PATCH 1/2] Maple Bus support for SEGA Dreamcast

[Mike F. <va...@ge...>]

On Monday 10 September 2007, Adrian McMenamin wrote:
> +config MAPLE
> +	tristate "Maple Bus Support"
> +	depends on SH_DREAMCAST
> +	help
> +	  The Maple Bus is SEGA's serial communication bus for peripherals
> +	  on the Dreamcast. Without this bus support you won't be able to
> +	  get your Dreamcast keyboard etc to work, so most users
> +	  probably want to say 'Y' here, unless you are only using the
> +	  Dreamcast with a serial line terminal or a remote network
> +	  connection.

hmm, tristate means you can build it as a module ... so please add a line t=
hat=20
says what the module name is if 'M' is selected ...

> --- a/drivers/sh/Makefile
> +++ b/drivers/sh/Makefile
> +obj-$(CONFIG_MAPLE) +=3D maple/

ok ...

> --- /dev/null
> +++ b/drivers/sh/maple/Makefile
> +obj-y	:=3D maplebus.o

erp, shouldnt that be obj-$(CONFIG_MAPLE) ?
=2Dmike