Re: [PATCH/FIX] hp680 backlight compile fix

[Kristoffer E. <kri...@gm...>]

Greetings,

shortlog:
Trivial compile fix

Signed-off-by: Kristoffer Ericson <kri...@gm...>

diff --git a/drivers/video/backlight/hp680_bl.c b/drivers/video/backlight/hp680_bl.c
index 0899fcc..fbea2bd 100644
--- a/drivers/video/backlight/hp680_bl.c
+++ b/drivers/video/backlight/hp680_bl.c
@@ -125,8 +125,8 @@ static int hp680bl_remove(struct platform_device *pdev)
 {
 	struct backlight_device *bd = platform_get_drvdata(pdev);
 
-	hp680bl_data.brightness = 0;
-	hp680bl_data.power = 0;
+	bd->props.brightness = 0;
+	bd->props.power = 0;
 	hp680bl_send_intensity(bd);
 
 	backlight_device_unregister(bd);



On Fri, 24 Aug 2007 10:53:48 +0900
Paul Mundt <le...@li...> wrote:

> On Thu, Aug 23, 2007 at 02:49:39PM -0700, Kristoffer Ericson wrote:
> > --- a/drivers/video/backlight/hp680_bl.c
> > +++ b/drivers/video/backlight/hp680_bl.c
> > @@ -125,8 +125,8 @@ static int hp680bl_remove(struct platform_device *pdev)
> >  {
> >  	struct backlight_device *bd = platform_get_drvdata(pdev);
> >  
> > -	hp680bl_data.brightness = 0;
> > -	hp680bl_data.power = 0;
> > +//	hp680bl_data.brightness = 0;
> > +//	hp680bl_data.power = 0;
> >  	hp680bl_send_intensity(bd);
> >  
> >  	backlight_device_unregister(bd);
> > 
> Don't do things like this. It does nothing to fix the problem, and it's
> fairly obvious what the problem is. If there have been API changes, then
> look at the other drivers and see how they have dealt with this. Just
> from a 2 second glance, it's obvious that bd->props.{brightness,power}
> are what you want to clear, as hp680bl_data has been removed completely.
> 
> Simply hacking it to build will generally cause more problems than it
> solves, whereas actually thinking about the problem will net you much
> better results in the end.


-- 
Kristoffer Ericson <Kri...@Gm...>