Re: rts7751r2d cf_ide rework

[Magnus D. <mag...@gm...>]

Hi there,

On 9/1/07, shinkoi2005 <shi...@gm...> wrote:
> Hi all.
>
> I have a problem about rts7751r2d.

First of all, which board version are you using? It looks like your
patch is targeted for R2D-1. I think CF support is disabled for R2D-1
just because of the problem your patch is trying to solve.

The code that your patch modifies is used by both R2D-PLUS and R2D-1.
I suspect that your current patch breaks R2D-PLUS. Or at least
degrades it to 8 bit read. If these board versions doesn't make any
sense to you then please read the help text for the new R2D specific
board code available in the git tree that now is targeted for 2.6.24:

http://git.kernel.org/?p=linux/kernel/git/lethal/sh-2.6.git;a=summary

A few random hints:

Please wrap your changes with CONFIG_RTS7751R2D_1 and make sure that
CONFIG_RTS7751R2D_PLUS still compiles. Also, please add a signed-off
line and make sure your patch applies to the tree above, not
2.6.23-rc. But I think you are already working against the sh-2.6
tree, right?

Besides that I'm not sure if your patch is 100% correct. I know Paul
is busy this week but maybe he has some comments later on.

Is the libata code working properly with 8 bit reads? Is this patch
all it takes to get CF working on R2D-1?

Thanks for your help.

/ magnus