Re: [PATCH] Add support for generic maple bus and for maple bus keyboard

[Mike F. <va...@ge...>]

On Wednesday 29 August 2007, Adrian McMenamin wrote:
> On Wed, August 29, 2007 2:36 am, Mike Frysinger wrote:
> > On Tuesday 28 August 2007, Adrian McMenamin wrote:
> >> --- /dev/null
> >> +++ b/drivers/input/keyboard/maple_keyb.c
> >> @@ -0,0 +1,210 @@
> >> +/*
> >> + *	SEGA Dreamcast keyboard driver
> >> + *	Based on drivers/usb/usbkbd.c
> >> + *	Copyright YAEGASHI Takeshi, 2001
> >> + *	Porting to 2.6 Copyright Adrian McMenamin, 2007
> >> + *	Licensed under the GPL
> >
> > you mean GPL-2 [or later] ?
>
> Actually, I don't know. The original just said "GPL" and as it was
> submitted to the kernel we can assume it's at least v2 but there was no
> additional specification given. Shall I just leave it as is?

if the old file only said "Licensed under the GPL" then i guess you dont ha=
ve=20
much choice without contacting the people who wrote the original

> >> +static struct maple_driver dc_kbd_driver =3D {
> >> +	.function =3D 	MAPLE_FUNC_KEYBOARD,
> >> +	.connect =3D 	dc_kbd_connect,
> >> +	.disconnect =3D 	dc_kbd_disconnect,
> >> +	.drv =3D {
> >> +		.name =3D 	"Dreamcast_keyboard",
> >> +		.bus =3D 		&maple_bus_type,
> >> +		.probe =3D 	probe_maple_kbd,},
> >
> > that last "}," shouldnt be cuddled like that
>
> Really? It's what i've used before and it has been accepted into the
> kernel.
>
> Should it be
>               .probe =3D      probe_maple_kbd,
>               },
>
> then?

=2Edev =3D {
	.moo =3D cow,
	.foo =3D bar,
},

> >> +/* use init call to ensure bus is registered ahead of devices */
> >> +fs_initcall(maple_bus_init);
> >
> > thought subsys_initcall() was what you wanted ?
>
> I thought it would be better behaved to use a later call and as this is fs
> related (sys) it seemed appropriate. If this a faux pas I can change it...

Paul would know
=2Dmike