Re: [PATCH/FIX] hp680 backlight compile fix

[Paul M. <le...@li...>]

On Thu, Aug 23, 2007 at 02:49:39PM -0700, Kristoffer Ericson wrote:
> --- a/drivers/video/backlight/hp680_bl.c
> +++ b/drivers/video/backlight/hp680_bl.c
> @@ -125,8 +125,8 @@ static int hp680bl_remove(struct platform_device *pdev)
>  {
>  	struct backlight_device *bd = platform_get_drvdata(pdev);
>  
> -	hp680bl_data.brightness = 0;
> -	hp680bl_data.power = 0;
> +//	hp680bl_data.brightness = 0;
> +//	hp680bl_data.power = 0;
>  	hp680bl_send_intensity(bd);
>  
>  	backlight_device_unregister(bd);
> 
Don't do things like this. It does nothing to fix the problem, and it's
fairly obvious what the problem is. If there have been API changes, then
look at the other drivers and see how they have dealt with this. Just
from a 2 second glance, it's obvious that bd->props.{brightness,power}
are what you want to clear, as hp680bl_data has been removed completely.

Simply hacking it to build will generally cause more problems than it
solves, whereas actually thinking about the problem will net you much
better results in the end.