Re: [PATCH 3/5] SH7720: MPR2: basic support

[Paul M. <le...@li...>]

On Mon, Aug 20, 2007 at 01:24:24PM +0200, EXTERNAL Brunner Markus (Praktikant; ST-FIR/Eng) wrote:
> > Try this patch with the regsize and inversion bit set in your platform
> > data. Works fine for me, but you might want to confirm that everything
> is
> > still functional.
> 
> The patch won't compile. 
> You forgot the address operator on all those lines.
> +		.platform_data	= heartbeat_data,
> 
> Should be
> +		.platform_data	= &heartbeat_data,
> 
> But after that everything is fine.
> 
Ah, right, I had that in my testing tree but missed it in the patch.

> What about cleaning up the iomem confusion?
> All boards have/had something like
> 
>  		.start  = PA_LED,
> 		.end    = PA_LED + ARRAY_SIZE(heartbeat_bit_pos) - 1,
> 
> For most boards "end" is by 7 bigger than "start". So 8 BYTES of iomem 
> will be requested, but only 8 BITS should be requested.

Yes, that was intentionally bogus when we didn't have a way to figure out
the number of bits. I'll change that now that we pass the nr_bits in
explicitly.