Re: [PATCH 3/5] SH7720: MPR2: basic support

[EXTERNAL B. M. (P. ST-FIR/Eng) <ext...@de...>]

> Try this patch with the regsize and inversion bit set in your platform
> data. Works fine for me, but you might want to confirm that everything
is
> still functional.

The patch won't compile.=20
You forgot the address operator on all those lines.
+		.platform_data	=3D heartbeat_data,

Should be
+		.platform_data	=3D &heartbeat_data,

But after that everything is fine.



What about cleaning up the iomem confusion?
All boards have/had something like

 		.start  =3D PA_LED,
		.end    =3D PA_LED + ARRAY_SIZE(heartbeat_bit_pos) - 1,

For most boards "end" is by 7 bigger than "start". So 8 BYTES of iomem=20
will be requested, but only 8 BITS should be requested.