Re: [PATCH 2/5] SH7720: SH7720 CPU support

[Paul M. <le...@li...>]

On Sat, Aug 18, 2007 at 12:39:15AM +0200, Markus Brunner wrote:
> Because there was no reply to my patch extracting the bitpositions for the
> clocks into a dedicated file and have a generic colck-sh3.c, I used
> clock-sh7710.c for the sh7720. 
> http://marc.info/?l=linuxsh-dev&m=118661270309548&w=2

I still have to think about this a bit, but it hasn't fallen off of my
stack completely. Now that Obon is over, I'll try to look at it shortly.

> Both CPUs have the same clock layout, however the sh7710 clock module is a bit
> confusing. The bitmasks are 3 bit wide, but the CPU has only 2 bit wide 
> fields.
> On both CPUs the additional bit is always read as 0, so this is no problem.
> 
> Early_printk support was added. A init function for sh7720 was added.
> The scif_sercon_putc could be reused, but the FIFO size got adjusted with an 
> ifdef.
> 
Looks fine. I'll apply this and the PFC/GPIO stuff with a bit of header
tidying and push it out to the 2.6.24 tree, thanks.