AW: sh: intc - primary priority masking fixes

[EXTERNAL B. M. (P. ST-FIR/Eng) <ext...@de...>]

Hi,

I didn't have access to the hardware yesterday.

> Markus, could you please fix this by hand and check if the patch is
ok?

The patch needed another fix. It was my old friend "!" =3D)
After that it worked.

-	if (!primary) {
+	if (primary) {
		/*
		 * only secondary priority should access registers, so
		 * set _INTC_FN(h) =3D REG_FN_ERR for intc_set_priority()
		 */

I don't have problems with "!" in conditions, because it's a logical
operator in a logical condition and it's not a not not in a numerical
calculation ;)



I think the way you check handle against REG_FN_ERR is problematic. You
set it with a binary or,

+			hp->handle &=3D ~_INTC_MK(0x0f, 0, 0, 0, 0, 0);
+			hp->handle |=3D _INTC_MK(REG_FN_ERR, 0, 0, 0, 0,
0);

but you check it directly.

         if (_INTC_FN(ihp->handle) !=3D REG_FN_ERR)




I'm already hunting the next bug.=20
It seems to be without influence on the functionality. The value of
"handle" for the sense is also wrong.
So I better find the bug before it finds us ;)

Markus