Re: intc - rework core code

[Magnus D. <mag...@gm...>]

Hi Markus!

On 8/14/07, EXTERNAL Brunner Markus (Praktikant; ST-FIR/Eng)
<ext...@de...> wrote:
> Greetings
>
> ...
> > I wanted to keep it semi-secret ...
>
> That reminds me on your way you access arrays ;-)

=)

> I've never seen things like
> data[!primary]
> before and was really surprised it works. What about
> data[1 - primary]
> or
> data[1 ^ primary]
> If you ask me this is easier to understand and more important this
> complies with any C implementation.
> The C standard defines false as 0 and any other value is defined as
> true. So !0 could be anything.

Does this mean that you dislike the idea of "!!" as well? =)
Grep the kernel sources and you'll find that here and there...

I think it's important that people easily can read and understand the
code, but I'm not sure if your proposal makes it any more readable.
Feel free to cook up a patch and if other people prefer that as well
then I'm all for it. =)

> > I'll post fixes in a little while. Thank you!
>
> Great! I'm looking forward to your fix.

Ok, I've just posted the patch. Please let me know if it solves your problem.

> I'm already cleaning up my SH7720 patch, so I will send it out the next
> days.

Excellent. Having support for sh7720 in 2.6.24 would be nice.

Thanks!

/ magnus