Re: sh: intc - mark data structures as __initdata

[Magnus D. <mag...@gm...>]

On 8/10/07, Paul Mundt <le...@li...> wrote:
> On Fri, Aug 10, 2007 at 08:59:04PM +0900, Magnus Damm wrote:
> > @@ -57,8 +57,8 @@ static struct intc_mask_reg mask_registe
> >           0, UH, 0, 0, TWOD, ZD, PV, CI } },
> >  };
> >
> > -static DECLARE_INTC_DESC(intc_desc, "voyagergx", vectors,
> > -                      NULL, NULL, mask_registers, NULL, NULL);
> > +static __initdata DECLARE_INTC_DESC(intc_desc, "voyagergx", vectors,
> > +                                 NULL, NULL, mask_registers, NULL, NULL);
> >
> >  static unsigned int voyagergx_stat2irq[32] = {
> >       IRQ_SM501_CI, IRQ_SM501_PV, IRQ_SM501_ZD, IRQ_SM501_2D,
>
> I wonder if it makes more sense to include __initdata in the
> DECLARE_INTC_DESC() itself? Is there ever going to be a situation where
> it's not going to be initdata now that you're copying them out anyways?

Including the __initdata in DECLARE_INTC_DESC() makes sense. I'll
resend in a bit.

Thanks!

/ magnus