Re: [PATCH] Add SH7720 CPU support

[Paul M. <le...@li...>]

Just another point (In addition to what Manuel already said about the
ethernet bits)..

On Mon, Jul 23, 2007 at 09:15:01AM +0200, Markus Brunner wrote:
> diff -upNr linux-2.6.22-rc7-orig/drivers/serial/sh-sci.h linux-2.6.22-rc7-mod-CPU/drivers/serial/sh-sci.h
> --- linux-2.6.22-rc7-orig/drivers/serial/sh-sci.h	2007-07-04 10:31:28.000000000 +0200
> +++ linux-2.6.22-rc7-mod-CPU/drivers/serial/sh-sci.h	2007-07-20 18:02:16.000000000 +0200
> @@ -23,6 +24,8 @@
>  #endif
>  #endif
>  
> +#include <asm/port.h>
> +
>  #if defined(CONFIG_CPU_SUBTYPE_SH7708)
>  # define SCSPTR 0xffffff7c /* 8 bit */
>  # define SCSCR_INIT(port)          0x30 /* TIE=0,RIE=0,TE=1,RE=1 */

Be very careful when making these changes, sh-sci is used by 3 different
architectures: sh, sh64, and h8300. I suggest just killing the ifdefs
around the gpio.h that H8300 currently employs, and using that outright.
We can have the asm-sh/gpio.h version wrap in to port.h or whatever else
for the PFC definitions, as they're going to be pretty tightly coupled
from an API point of view anyways. Likewise, we can just stub out gpio.h
on sh64, it has some that are probably worth hooking up, but I can't
really be bothered ;-)