Re: sh: intc - shared IPR and INTC2 controller

[Paul M. <le...@li...>]

On Wed, Jul 18, 2007 at 10:20:36AM +0900, Magnus Damm wrote:
> +void (*intc_reg_fns[])(struct intc_desc *, unsigned int) = {
> +	NULL, /* index 0 used as error code */ 
> +	enable_mask_8, disable_mask_8, 
> +	enable_mask_32, disable_mask_32, 
> +	enable_prio_16, disable_prio_16,
> +	enable_prio_32, disable_prio_32,
> +};
> +
Shouldn't this be static?

> +static void intc_enable(unsigned int irq)
> +{
> +	struct intc_desc *desc = get_intc_desc(irq);
> +	unsigned int data = (unsigned int) get_irq_chip_data(irq);
> +
> +	intc_reg_fns[_INTC_FN(data)](desc, data);
> +}
> +
> +static void intc_disable(unsigned int irq)
> +{
> +	struct intc_desc *desc = get_intc_desc(irq);
> +	unsigned int data = (unsigned int) get_irq_chip_data(irq);
> +
> +	intc_reg_fns[_INTC_FN(data) + 1](desc, data);
> +}
> +

Hmm.. this should probably be reworked a little, it looks a little
clunky, and the + 1 thing isn't obvious without first looking at
intc_reg_fns[].