Re: Conflicting types for '__div64_32'

[Paul M. <pau...@re...>]

On Thu, Jun 21, 2007 at 09:45:51PM +0900, Paul Mundt wrote:
> On Thu, Jun 21, 2007 at 07:34:19PM +0900, Katsuya MATSUBARA wrote:
> >  I found an inconsistent declaration
> >  in arch/sh/lib/div-generic.c in 2.6.21.
> > 
> >  the function 'div64_32()' in arch/sh/lib/div64-generic.c
> >  returns a value of u64 type,
> >  but the declaration of that function is
> > 
> >  extern uint32_t __div64_32(uint64_t *dividend, uint32_t divisor);
> >         ^^^^^^^^
> >  in include/asm-generic/div64.h
> >  (which is referred by include/asm-sh/div64.h).
> > 
> Yes, div64_32() should be uint32_t, the result is passed back in r0, so
> the u64 thing is pointless. I'll queue up a patch, but probably won't get
> around to looking at it until after OLS.
> 
Pushed out a fix to current git.