Re: [PATCH] race in parallel out-of-tree build

[Paul M. <le...@li...>]

On Wed, Jun 20, 2007 at 07:58:55AM +0100, Johansson Erik-EJO017 wrote:
> > -----Original Message-----
> > From: Paul Mundt [mailto:le...@li...]
> > which went in during the 2.6.16-rc1 merge window. So even your 2.6.17
> > tree should have this. Both of these are also FORCE'd (which is also
> > in the phony targets), so the race you describe should be impossible.
> > Confused.
> 
> Yes, we have it in our tree as well. The problem is that when building
> in parallel, the maketools target may be built before .cpu and .mach,
> resulting in a missing asm-sh directory. FORCE only forces the targets
> to be built every time, it doesn't force the ordering.
> 
Hmm.. Have you actually seen this as a problem? An easy way to reproduce,
or at least a log of the error would be nice. I don't seem to have any
luck reproducing this. maketools depends on version.h, which is generated
by prepare1 in the top-level, which comes after archprepare in the .PHONY
list. The dependency ordering is explicit, in that each stage depends on
the previous one, so I still don't see anything wrong here. On the other
hand, if this is a valid bug, ARM also has this problem.