Re: [PATCH] rework ipr code

[Paul M. <le...@li...>]

On Fri, Jun 15, 2007 at 06:29:17PM +0900, Magnus Damm wrote:
> sh: rework ipr code
> 
> This patch reworks the ipr code by grouping the offset array together with the
> ipr_data structure in a new data structure called ipr_desc. This new structure
> also contains the name of the controller in struct irq_chip. The idea behind 
> putting struct irq_chip in there is that we can use offsetof() to locate the 
> base addresses in the irq_chip callbacks. This strategy has much in common
> with the recently merged intc2 code.
> 
> One logic change has been made - the original ipr code enabled the interrupts
> by default but with this patch they are all disabled by default.
> 
Thanks, this sort of thing has been needed for some time. I suppose the
next step is to rip out the IPR defines from the headers, where they're
still lingering around. I killed off most of those during the great IRQ
conversion of 9a7ef6d59f9d4780ff5bc9c4d05266b52dcb9211, but there's still
a bit to do.

>  Applies to the sh-2.6.23 development tree.
>  Modified files compiles for all cpus and boards below.
>  Boots and works fine on RTS7751R2D board.
> 
Also verified on SH7722, SH7780, and SH7785.

I've applied it and pushed it out, folks using something other than those
listed CPU subtypes are advised to test in the near future.