From: Kristoffer E. <kri...@gm...> - 2007-05-14 22:58:55
|
Bugtracking the hp6xx_apm functions and ran into some question marks. This happend after the apm merger so its not a big suprise. Doesn't seem to be many systems using apm in arch/sh though. Problems: 1. Once powerbutton is hit IRQ 32 is generated and never stops Best approach? Clear request bit? But will that stop anything since a new request will be created before the power button can be released. 2. mutex_lock(&state_lock); from apm-emulation.c seems to freeze the machine. adding a ifndef config_cpu_subsystem.. makes it run abit longer. I noticed that the mutex lock wasn't in the "old" version. Suggestions? 3. Getting apm: apm queue event overflowed before it freezes (freezes probably due to some mutex locks I've missed), this would indicate that more than one request is sent by the apm interrupt handler? 4. PM_DISK_FIRMWARE is removed, but im not sure if that will be an issue since the pm is handled by board specific code which doesn't require anything to be saved. It simply turns off all clocks besides tmu/rtc and drops power to lcd/pcmcia. Ram shouldn't be cleared. In short I need a good way for the interrupt handler to make sure only one request is sent and someway to get rid off / fix the mutex_lock. It would get ugly with alot of ifdefs but dont see any other solution currently. |