Re: HP6xx/sh7709 patches - 1

[Paul M. <le...@li...>]

On Fri, Mar 23, 2007 at 07:40:31PM +0000, Kristoffer Ericson wrote:
> diff --git a/arch/sh/boards/hp6xx/setup.c b/arch/sh/boards/hp6xx/setup.c
> index b5a9664..266c338 100644
> --- a/arch/sh/boards/hp6xx/setup.c
> +++ b/arch/sh/boards/hp6xx/setup.c
> @@ -15,10 +15,45 @@
>  #include <asm/irq.h>
>  #include <asm/hp6xx.h>
>  #include <asm/cpu/dac.h>
> +#include <linux/platform_device.h>
>  
linux/ includes before asm/ includes..

> +static struct resource cf_ide_resources[] = {
> +              [0] = {
> +	              .start = 0xb5000000 + 0x1f0,
> +		      .end   = 0xb5000000 + 0x1f0 + 0x08 - 1,
> +		      .flags = IORESOURCE_MEM,
> +		    },
> +	      [1] = { 
> +	              .start = 0xb5000000 + 0x1fe,
> +		      .end   = 0xb5000000 + 0x1fe + 1,
> +		      .flags = IORESOURCE_MEM,
> +		    },
> +	      [2] = {
> +	              .start = 93,
> +		      .flags = IORESOURCE_IRQ,
> +		    }, 
> +};
> +
This has some very strange whitespace, please check for space errors
before making the diff.

I suspect you also ant to use 0x15000000 here rather than 0xb5, since you
set the resouce type to MEM it will be remapped and you'll get back
0xb5.. anyways.

>  	.mv_irq_demux = hd64461_irq_demux,
> +        .mv_readw  = hd64461_readw,
> +	.mv_writew = hd64461_writew,
>  };

Any reason for keeping these?