Re: Patches for HP6xx platform

[Paul M. <le...@li...>]

On Tue, Feb 20, 2007 at 01:45:57AM +0000, Kristoffer Ericson wrote:
> Finally got around to do some test builds. Didnt get very far. I've been 
> tracking down the changes and got a first set of patches.
> 
A minor nit. When submitting patches to the list, can you please use
text/plain instead of text/x-patch or something equally fancy? Some
mailers are rather fond of the latter, but replying to the patches inline
requires manual mangling of the mime type, and while I do have a macro
for this, I rather wish I didn't.

> Touchscreen patch fixes the change DECLARE_WORK(1,2,3) ->
> DECLARE_WORK(1.2) that has taken place.
> 
This looks fine. Please send a Signed-off-by tag for these.

> Pint.c requires some variables to work properly. I've taken those from the 
> old irq.h file. Im not sure if those are bound to the hp6xx platform and if 
> so where they should go.
> 
These should probably move in to the hp6xx-specific parts and be handed
off, but I'm currently overhauling some of how we do that, so you may
want to hold off on some of that and just use this patch locally until
then.

> +#define INTC_IPRD 0xffd0010UL
> +#define INTC_ICR2 0xa4000012UL
> +#define PORT_PCCR 0xA4050104UL
> +#define PORT_PCDR 0xA4050106UL
> +#define PORT_PFDR 0xa400012aUL
> +#define PORT_PFCR 0xa405010AUL
> +

IPRD is completely bogus. Copy and paste error, or was this always wrong?