linuxsh-dev

[linuxsh-dev] #pragma pack

[Bryan R. <br...@ix...>]

Hi,

I've been working on building the latest CVS kernel using the older
toolchain and gnb's patch:
http://sourceforge.net/patch/download.php?id=103106

and I keep getting lots of these:

---
sh-linux-gnu-gcc -D__KERNEL__ -I/home/bryan/src/sh/kernel/include -Wall
-Wstrict-prototypes -O2 -fomit-frame-pointer -fno-strict-aliasing -ml
-m4 -pipe   -c -o init/main.o init/main.c
In file included from /home/bryan/src/sh/kernel/include/linux/fs.h:658,
                 from
/home/bryan/src/sh/kernel/include/linux/capability.h:17,
                 from
/home/bryan/src/sh/kernel/include/linux/binfmts.h:5,
                 from /home/bryan/src/sh/kernel/include/linux/sched.h:9,
                 from /home/bryan/src/sh/kernel/include/linux/mm.h:4,
                 from /home/bryan/src/sh/kernel/include/linux/slab.h:14,
                 from
/home/bryan/src/sh/kernel/include/linux/malloc.h:4,
                 from
/home/bryan/src/sh/kernel/include/linux/proc_fs.h:5,
                 from init/main.c:15:
/home/bryan/src/sh/kernel/include/linux/udf_fs_sb.h:21: warning:
ignoring pragma: pack
/home/bryan/src/sh/kernel/include/linux/udf_fs_sb.h:76: warning:
ignoring pragma: pack
---

I've run into the same warning when porting some of our in-house code...
does the old toolchain not implement #pragma pack? If not, why not, and
will the new one?

In the meantime, I've applied my following patch (hack?):

--- udf_fs_sb-old.h     Thu Jan  4 21:57:34 2001
+++ udf_fs_sb.h Thu Jan  4 21:58:04 2001
@@ -18,7 +18,9 @@
 #if !defined(_LINUX_UDF_FS_SB_H)
 #define _LINUX_UDF_FS_SB_H
 
+#if !defined(__sh__)
 #pragma pack(1)
+#endif
 
 #define UDF_MAX_BLOCK_LOADED   8
 
@@ -73,7 +75,9 @@
        __u16   s_partition_flags;
 };
 
+#if !defined(__sh__)
 #pragma pack()
+#endif
 
 struct udf_sb_info
 {

---

Regards,

Bryan


-- 
Bryan Rittmeyer
mailto:br...@ix...
Ixia Communications
26601 W. Agoura Rd.
Calabasas, CA 91302

Re: [linuxsh-dev] #pragma pack

[Greg B. <gb...@po...>]

Bryan Rittmeyer wrote:
> 
> Hi,
> 
> I've been working on building the latest CVS kernel using the older
> toolchain and gnb's patch:
> http://sourceforge.net/patch/download.php?id=103106
> 
> and I keep getting lots of these:
> 
> ---
> sh-linux-gnu-gcc -D__KERNEL__ -I/home/bryan/src/sh/kernel/include -Wall
> -Wstrict-prototypes -O2 -fomit-frame-pointer -fno-strict-aliasing -ml
> -m4 -pipe   -c -o init/main.o init/main.c
> In file included from /home/bryan/src/sh/kernel/include/linux/fs.h:658,
>                  from
> /home/bryan/src/sh/kernel/include/linux/capability.h:17,
>                  from
> /home/bryan/src/sh/kernel/include/linux/binfmts.h:5,
>                  from /home/bryan/src/sh/kernel/include/linux/sched.h:9,
>                  from /home/bryan/src/sh/kernel/include/linux/mm.h:4,
>                  from /home/bryan/src/sh/kernel/include/linux/slab.h:14,
>                  from
> /home/bryan/src/sh/kernel/include/linux/malloc.h:4,
>                  from
> /home/bryan/src/sh/kernel/include/linux/proc_fs.h:5,
>                  from init/main.c:15:
> /home/bryan/src/sh/kernel/include/linux/udf_fs_sb.h:21: warning:
> ignoring pragma: pack
> /home/bryan/src/sh/kernel/include/linux/udf_fs_sb.h:76: warning:
> ignoring pragma: pack

  That's right.  I said it compiles, I didn't say it compiles cleanly ;-)
The situation with the new toolchain is currently even worse, due to the
whole $ in register names business.


> ---
> 
> I've run into the same warning when porting some of our in-house code...
> does the old toolchain not implement #pragma pack? If not, why not, and
> will the new one?
> 
> In the meantime, I've applied my following patch (hack?):
> 
> --- udf_fs_sb-old.h     Thu Jan  4 21:57:34 2001
> +++ udf_fs_sb.h Thu Jan  4 21:58:04 2001
> @@ -18,7 +18,9 @@
>  #if !defined(_LINUX_UDF_FS_SB_H)
>  #define _LINUX_UDF_FS_SB_H
> 
> +#if !defined(__sh__)
>  #pragma pack(1)
> +#endif
> 
>  #define UDF_MAX_BLOCK_LOADED   8
> 
> @@ -73,7 +75,9 @@
>         __u16   s_partition_flags;
>  };
> 
> +#if !defined(__sh__)
>  #pragma pack()
> +#endif
> 
>  struct udf_sb_info
>  {
> 


  Sure its a hack.  But are you going to be mounting DVDs?

Greg.
-- 
These are my opinions not PPIs.

Re: [linuxsh-dev] #pragma pack

[Bryan R. <br...@ix...>]

Greg Banks wrote:

>   That's right.  I said it compiles, I didn't say it compiles cleanly ;-)
> The situation with the new toolchain is currently even worse, due to the
> whole $ in register names business.

Ugh. I just dealt with some pretty nasty stuff, even with the old
toolchain. Namely, the use of "'" in !'d assembly comments. Apparently,
they now cause "unterminated character constant" errors. I just went
through by hand and removed them from entry.S, memmove.S, etc... I never
saw this before with the old kernel code, and I have a hard time
believing it doesn't have any "'"s in ! comments, but oh well.
2.4.0-prerelease is building now, with the old toolchain.

Shrug. New kernel and old tools still tops an old kernel with old
tools...

>   Sure its a hack.  But are you going to be mounting DVDs?

Exactly my reasoning. :)

Regards,

Bryan

-- 
Bryan Rittmeyer
mailto:br...@ix...
Ixia Communications
26601 W. Agoura Rd.
Calabasas, CA 91302

Re: [linuxsh-dev] #pragma pack

[Greg B. <gb...@po...>]

Bryan Rittmeyer wrote:
> 
> Greg Banks wrote:
> 
> >   That's right.  I said it compiles, I didn't say it compiles cleanly ;-)
> > The situation with the new toolchain is currently even worse, due to the
> > whole $ in register names business.
> 
> Ugh. I just dealt with some pretty nasty stuff, even with the old
> toolchain. Namely, the use of "'" in !'d assembly comments. Apparently,
> they now cause "unterminated character constant" errors. I just went
> through by hand and removed them from entry.S, memmove.S, etc... I never
> saw this before with the old kernel code, and I have a hard time
> believing it doesn't have any "'"s in ! comments, but oh well.
> 2.4.0-prerelease is building now, with the old toolchain.

  No, this is actually a Makefile problem.  You need to have
the -traditional flag to the assembler runs, then the warnings about
unterminated char constants go away.  Only a few days ago I checked
in some LinuxSH Makefile tweaks to make that happen properly. I'll
go see if they're still there.

Greg.
-- 
These are my opinions not PPIs.

Re: [linuxsh-dev] #pragma pack

[Greg B. <gb...@po...>]

Greg Banks wrote:
> 
> Bryan Rittmeyer wrote:
> >
> > [...] "unterminated character constant" errors. [...]
> 
>   No, this is actually a Makefile problem.  You need to have
> the -traditional flag to the assembler runs, then the warnings about
> unterminated char constants go away.  Only a few days ago I checked
> in some LinuxSH Makefile tweaks to make that happen properly. I'll
> go see if they're still there.

  Ooops, my changes disappeared in the 2.4.0-test13-pre4 merge.  I'll
work on fixing the repository, but what you need to do is add the
following line to the Makefile in the directories where you had this
problem.

EXTRA_AFLAGS :=         -traditional


Greg.
-- 
These are my opinions not PPIs.