linuxsh-dev

rip out broken boards

[Magnus D. <mag...@gm...>]

Hi everyone,

Here is a list of boards that doesn't compile in the 2.6.23
development tree [1]:

CONFIG_SH_7710VOIPGW
CONFIG_SH_7300_SOLUTION_ENGINE
CONFIG_SH_73180_SOLUTION_ENGINE
CONFIG_SH_7343_SOLUTION_ENGINE

All boards above seem to use constants related to ipr irq tables that
are nowhere to be found. Unless someone steps up and fixes this I
suggest that we rip them out from the tree. There is no point in
keeping broken boards in the tree. We can always re-add them properly
later on.

[1] http://git.kernel.org/?p=linux/kernel/git/lethal/sh-2.6.23.git;a=summary

Thanks,

/ magnus

Re: rip out broken boards

[Paul M. <le...@li...>]

On Fri, Jun 15, 2007 at 04:59:05PM +0900, Magnus Damm wrote:
> Here is a list of boards that doesn't compile in the 2.6.23
> development tree [1]:
> 
> CONFIG_SH_7300_SOLUTION_ENGINE
> CONFIG_SH_73180_SOLUTION_ENGINE

Killing these off seems fine, I doubt there are any users left for any of
these.

> CONFIG_SH_7710VOIPGW
> CONFIG_SH_7343_SOLUTION_ENGINE
> 
These there are users for, but they're mostly stuck on older kernels. It
would be worth keeping them at least partially working until they've had
a chance to rebase. I also do not have hardware for the first one, so
this is fairly difficult to verify.

Re: rip out broken boards

[Magnus D. <mag...@gm...>]

On 6/15/07, Paul Mundt <le...@li...> wrote:
> On Fri, Jun 15, 2007 at 04:59:05PM +0900, Magnus Damm wrote:
> > Here is a list of boards that doesn't compile in the 2.6.23
> > development tree [1]:
> >
> > CONFIG_SH_7300_SOLUTION_ENGINE
> > CONFIG_SH_73180_SOLUTION_ENGINE
>
> Killing these off seems fine, I doubt there are any users left for any of
> these.

Will you remove them or do you want patches?

> > CONFIG_SH_7710VOIPGW
> > CONFIG_SH_7343_SOLUTION_ENGINE
> >
> These there are users for, but they're mostly stuck on older kernels. It
> would be worth keeping them at least partially working until they've had
> a chance to rebase. I also do not have hardware for the first one, so
> this is fairly difficult to verify.

Ok, I'll work on fixing up the 7343 board next week then. If anyone
else has time and that 7710 board handy then I'd be happy to help out
fixing that board as well.

/ magnus

Re: rip out broken boards

[Paul M. <le...@li...>]

On Fri, Jun 15, 2007 at 06:36:07PM +0900, Magnus Damm wrote:
> On 6/15/07, Paul Mundt <le...@li...> wrote:
> > On Fri, Jun 15, 2007 at 04:59:05PM +0900, Magnus Damm wrote:
> > > Here is a list of boards that doesn't compile in the 2.6.23
> > > development tree [1]:
> > >
> > > CONFIG_SH_7300_SOLUTION_ENGINE
> > > CONFIG_SH_73180_SOLUTION_ENGINE
> >
> > Killing these off seems fine, I doubt there are any users left for any of
> > these.
> 
> Will you remove them or do you want patches?
> 
Patches are always welcome, though it's probably worth waiting for a week
or so to see if anyone suddenly finds themselves interested in ancient
SH-Mobile support.. The person who did the 73180 port hasn't had the
hardware in years, at least.

> > > CONFIG_SH_7710VOIPGW
> > > CONFIG_SH_7343_SOLUTION_ENGINE
> > >
> > These there are users for, but they're mostly stuck on older kernels. It
> > would be worth keeping them at least partially working until they've had
> > a chance to rebase. I also do not have hardware for the first one, so
> > this is fairly difficult to verify.
> 
> Ok, I'll work on fixing up the 7343 board next week then. If anyone
> else has time and that 7710 board handy then I'd be happy to help out
> fixing that board as well.
> 
I have (older) trees for both of these if it's something you want to dig
in to. Most of that's just driver stuff, though.