linuxsh-dev

Patches for HP6xx platform

[Kristoffer E. <kri...@ho...>]

Greetings,

Finally got around to do some test builds. Didnt get very far. I've been 
tracking down the changes and got a first set of patches.

Paul, please give me some input on where to put the vars (if my location is 
correct).

Touchscreen patch fixes the change DECLARE_WORK(1,2,3) -> DECLARE_WORK(1.2) 
that
has taken place.

Pint.c requires some variables to work properly. I've taken those from the 
old irq.h file. Im not sure if those are bound to the hp6xx platform and if 
so where they should go.

All patches are against latest git

Best wishes
Kristoffer Ericson

_________________________________________________________________
Express yourself instantly with MSN Messenger! Download today it's FREE! 
http://messenger.msn.click-url.com/go/onm00200471ave/direct/01/

Re: Patches for HP6xx platform

[Paul M. <le...@li...>]

On Tue, Feb 20, 2007 at 01:45:57AM +0000, Kristoffer Ericson wrote:
> Finally got around to do some test builds. Didnt get very far. I've been 
> tracking down the changes and got a first set of patches.
> 
A minor nit. When submitting patches to the list, can you please use
text/plain instead of text/x-patch or something equally fancy? Some
mailers are rather fond of the latter, but replying to the patches inline
requires manual mangling of the mime type, and while I do have a macro
for this, I rather wish I didn't.

> Touchscreen patch fixes the change DECLARE_WORK(1,2,3) ->
> DECLARE_WORK(1.2) that has taken place.
> 
This looks fine. Please send a Signed-off-by tag for these.

> Pint.c requires some variables to work properly. I've taken those from the 
> old irq.h file. Im not sure if those are bound to the hp6xx platform and if 
> so where they should go.
> 
These should probably move in to the hp6xx-specific parts and be handed
off, but I'm currently overhauling some of how we do that, so you may
want to hold off on some of that and just use this patch locally until
then.

> +#define INTC_IPRD 0xffd0010UL
> +#define INTC_ICR2 0xa4000012UL
> +#define PORT_PCCR 0xA4050104UL
> +#define PORT_PCDR 0xA4050106UL
> +#define PORT_PFDR 0xa400012aUL
> +#define PORT_PFCR 0xa405010AUL
> +

IPRD is completely bogus. Copy and paste error, or was this always wrong?

Implementation of HP6xx keyboard driver?

[Kristoffer E. <kri...@ho...>]

Greetings,

Paul, any idea when the keyboard for hp6xx will be pushed into git?

Best wishes
Kristoffer Ericson

_________________________________________________________________
Express yourself instantly with MSN Messenger! Download today it's FREE! 
http://messenger.msn.click-url.com/go/onm00200471ave/direct/01/

Re: Patches for HP6xx platform

[Paul M. <le...@li...>]

On Wed, Feb 21, 2007 at 05:25:45PM +0000, Kristoffer Ericson wrote:
> Btw, usually I use git diff to create patches (this time I used diff). Im 
> guessing that git diff is preferred when sending you patches then?
> 
Yes, git diff will do fine if you've got a working tree. If you've
already checked things in locally then you can simply use something like 
'git format-patch --pretty=email <hash>'.

On Wed, Feb 21, 2007 at 11:18:22PM +0000, Kristoffer Ericson wrote:
> Paul, any idea when the keyboard for hp6xx will be pushed into git?
> 
There are some outstanding issues with it, I prepared a patch for Dmitry
but it still requires some attention. Someone with a vested interest in
hp6xx will have to take it the rest of the way, I can provide the patch
and comment mail off-list to whoever is interested.

Re: Patches for HP6xx platform

[Kristoffer E. <kri...@ho...>]

My boot problems still eludes me, my knowledge of how the offchip IRQ's are 
handled are not good enough currently. It doesnt seem to detect the hd64461 
CF card and thus is unable to boot from it.

Concerning keyboard:
I would be very much interested in that, so I can get a good idea what is 
needed.

Best wishes
Kristoffer

>From: Paul Mundt <le...@li...>
>To: Kristoffer Ericson <kri...@ho...>
>CC: lin...@li...
>Subject: Re: Patches for HP6xx platform
>Date: Fri, 23 Feb 2007 18:45:38 +0900
>
>On Wed, Feb 21, 2007 at 05:25:45PM +0000, Kristoffer Ericson wrote:
> > Btw, usually I use git diff to create patches (this time I used diff). 
>Im
> > guessing that git diff is preferred when sending you patches then?
> >
>Yes, git diff will do fine if you've got a working tree. If you've
>already checked things in locally then you can simply use something like
>'git format-patch --pretty=email <hash>'.
>
>On Wed, Feb 21, 2007 at 11:18:22PM +0000, Kristoffer Ericson wrote:
> > Paul, any idea when the keyboard for hp6xx will be pushed into git?
> >
>There are some outstanding issues with it, I prepared a patch for Dmitry
>but it still requires some attention. Someone with a vested interest in
>hp6xx will have to take it the rest of the way, I can provide the patch
>and comment mail off-list to whoever is interested.

_________________________________________________________________
Don't just search. Find. Check out the new MSN Search! 
http://search.msn.click-url.com/go/onm00200636ave/direct/01/