Re: [Linuxsampler-devel] cancel release on note on?

[Andreas P. <and...@lk...>]

Christian Schoenebeck wrote:
> But imagine the following case: you trigger key C3 the first time with a 
> velocity of 127, then you release key C3 and immediately after that press C3 
> again, but this time with a velocity of 1.
> 
> If we do what you claimed and remove those lines, you will hear nothing on the 
> 2nd key trigger. With current implementation though you still here the first 
> voice. Which makes sense, doesn't it?

Perhaps you're right. I wish I had a real piano nearby...

Anyway, I have now played a piano gig in LS with and without the cancel 
release in note on (that is, a practical test as opposed to the 
theoretical record-and-stare-at-zoomed-in-waveforms tests I did before), 
and: the difference is so subtle to me that my opinion on this almost 
faded away completely.

Just in case other type of instruments would behave differently, do you 
think it would be OK to insert "if (pInstrument->PianoReleaseMode)" 
around both cancel_release cases?

> I vote against that being the default behaviour. But of course if I'm alone 
> with that opinion I accepted it even as default behaviour.

My only argument for removing the lines per default would be that it 
makes the gig engine theoretically sound a little bit more like GS.

/Andreas